Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-circus,jest-jasmine2): throw when describe returns a value #10947

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Dec 13, 2020

Closes #8074

BREAKING CHANGE:
Returning a value from describe will now fail the test instead of just
warn.

BREAKING CHANGE:
Returning a value from `describe` will now fail the test instead of just
warn.
@jeysal jeysal requested a review from SimenB December 13, 2020 14:29
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@jeysal jeysal merged commit f1ae805 into jestjs:master Dec 14, 2020
@jeysal jeysal deleted the describe-return-error branch December 14, 2020 11:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail if describe returns a value
3 participants